Sample

pyint-4f5dbeedc6fc-I13

Lower every eligible synchronous for loop to a while loop

Matched original source

Lines319

Scores

MethodScoreScale
Posnett00–1; higher is more readable
Dorn0.0670–1; higher is more readable
Mi0.6160–1; higher is more readable
LLOC139Logical lines; fewer is more readable
DeepSeek V4 Pro12.330–20; mean of three runs
GPT-6.1 Sol150–20; mean of three runs
BTTF0.4090–1; higher is more readable

Views

Source code

from __future__ import annotations import os import sys import time from collections import OrderedDict from collections.abc import Generator, Mapping, MutableMapping from datetime import timedelta from typing import TYPE_CHECKING, Any, cast from ._internal_utils import to_native_string from ._types import is_prepared as _is_prepared from .adapters import HTTPAdapter from .auth import _basic_auth_str from .compat import cookielib, urljoin, urlparse from .cookies import ( RequestsCookieJar, cookiejar_from_dict, extract_cookies_to_jar, merge_cookies, ) from .exceptions import ( ChunkedEncodingError, ContentDecodingError, InvalidSchema, TooManyRedirects, ) from .hooks import default_hooks, dispatch_hook from .models import ( # noqa: F401 DEFAULT_REDIRECT_LIMIT, REDIRECT_STATI, PreparedRequest, Request, Response, ) from .status_codes import codes from .structures import CaseInsensitiveDict from .utils import ( # noqa: F401 DEFAULT_PORTS, default_headers, get_auth_from_url, get_environ_proxies, get_netrc_auth, requote_uri, resolve_proxies, rewind_body, should_bypass_proxies, # re-export for external consumers to_key_val_list, ) class SessionRedirectMixin: max_redirects: int trust_env: bool cookies: RequestsCookieJar def send(self, request: PreparedRequest, **kwargs: Any) -> Response: ... def get_redirect_target(self, resp: Response) -> str | None: """Receives a Response. Returns a redirect URI or ``None``""" # Due to the nature of how requests processes redirects this method will # be called at least once upon the original response and at least twice # on each subsequent redirect response (if any). # If a custom mixin is used to handle this logic, it may be advantageous # to cache the redirect location onto the response object as a private # attribute. if resp.is_redirect: location = resp.headers["location"] # Currently the underlying http module on py3 decode headers # in latin1, but empirical evidence suggests that latin1 is very # rarely used with non-ASCII characters in HTTP headers. # It is more likely to get UTF8 header rather than latin1. # This causes incorrect handling of UTF8 encoded location headers. # To solve this, we re-encode the location in latin1. location = location.encode("latin1") return to_native_string(location, "utf8") return None def should_strip_auth(self, old_url: str, new_url: str) -> bool: """Decide whether Authorization header should be removed when redirecting""" old_parsed = urlparse(old_url) new_parsed = urlparse(new_url) if old_parsed.hostname != new_parsed.hostname: return True # Special case: allow http -> https redirect when using the standard # ports. This isn't specified by RFC 7235, but is kept to avoid # breaking backwards compatibility with older versions of requests # that allowed any redirects on the same host. if ( old_parsed.scheme == "http" and old_parsed.port in (80, None) and new_parsed.scheme == "https" and new_parsed.port in (443, None) ): return False # Handle default port usage corresponding to scheme. changed_port = old_parsed.port != new_parsed.port changed_scheme = old_parsed.scheme != new_parsed.scheme default_port = (DEFAULT_PORTS.get(old_parsed.scheme, None), None) if ( not changed_scheme and old_parsed.port in default_port and new_parsed.port in default_port ): return False # Standard case: root URI must match return changed_port or changed_scheme def resolve_redirects( self, resp: Response, req: PreparedRequest, stream: bool = False, timeout: _t.TimeoutType = None, verify: _t.VerifyType = True, cert: _t.CertType = None, proxies: dict[str, str] | None = None, yield_requests: bool = False, **adapter_kwargs: Any, ) -> Generator[Response, None, None]: """Receives a Response. Returns a generator of Responses or Requests.""" hist: list[Response] = [] # keep track of history url = self.get_redirect_target(resp) previous_fragment = urlparse(req.url).fragment while url: prepared_request = req.copy() # Update history and keep track of redirects. resp.history = hist[:] hist.append(resp) try: resp.content # Consume socket so it can be released except (ChunkedEncodingError, ContentDecodingError, RuntimeError): resp.raw.read(decode_content=False) if len(resp.history) >= self.max_redirects: raise TooManyRedirects( f"Exceeded {self.max_redirects} redirects.", response=resp ) # Release the connection back into the pool. resp.close() # Handle redirection without scheme (see: RFC 1808 Section 4) if url.startswith("//"): parsed_rurl = urlparse(resp.url) url = ":".join([to_native_string(parsed_rurl.scheme), url]) # Normalize url case and attach previous fragment if needed (RFC 7231 7.1.2) parsed = urlparse(url) if parsed.fragment == "" and previous_fragment: parsed = parsed._replace(fragment=previous_fragment) elif parsed.fragment: previous_fragment = parsed.fragment url = parsed.geturl() # Facilitate relative 'location' headers, as allowed by RFC 7231. # (e.g. '/path/to/resource' instead of 'http://domain.tld/path/to/resource') # Compliant with RFC3986, we percent encode the url. if not parsed.netloc: url = urljoin(resp.url, requote_uri(url)) else: url = requote_uri(url) prepared_request.url = to_native_string(url) self.rebuild_method(prepared_request, resp) # https://github.com/psf/requests/issues/1084 if resp.status_code not in ( codes.temporary_redirect, codes.permanent_redirect, ): # https://github.com/psf/requests/issues/3490 purged_headers = ("Content-Length", "Content-Type", "Transfer-Encoding") loopIterator = __import__("builtins").iter(purged_headers) while True: try: header = __import__("builtins").next(loopIterator) except __import__("builtins").StopIteration: break prepared_request.headers.pop(header, None) prepared_request.body = None headers = prepared_request.headers headers.pop("Cookie", None) # Extract any cookies sent on the response to the cookiejar # in the new request. Because we've mutated our copied prepared # request, use the old one that we haven't yet touched. cookie_jar = cast("CookieJar", prepared_request._cookies) extract_cookies_to_jar(cookie_jar, req, resp.raw) merge_cookies(cookie_jar, self.cookies) prepared_request.prepare_cookies(cookie_jar) # Rebuild auth and proxy information. proxies = self.rebuild_proxies(prepared_request, proxies) self.rebuild_auth(prepared_request, resp) # A failed tell() sets `_body_position` to `object()`. This non-None # value ensures `rewindable` will be True, allowing us to raise an # UnrewindableBodyError, instead of hanging the connection. rewindable = prepared_request._body_position is not None and ( "Content-Length" in headers or "Transfer-Encoding" in headers ) # Attempt to rewind consumed file-like object. if rewindable: rewind_body(prepared_request) # Override the original request. req = prepared_request if yield_requests: yield req # type: ignore[misc] # Internal use only, returns PreparedRequest else: resp = self.send( req, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies, allow_redirects=False, **adapter_kwargs, ) extract_cookies_to_jar(self.cookies, prepared_request, resp.raw) # extract redirect url, if any, for the next loop url = self.get_redirect_target(resp) yield resp def rebuild_auth( self, prepared_request: PreparedRequest, response: Response ) -> None: """When being redirected we may want to strip authentication from the request to avoid leaking credentials. This method intelligently removes and reapplies authentication where possible to avoid credential loss. """ original_request = response.request assert _is_prepared(original_request) assert _is_prepared(prepared_request) headers = prepared_request.headers original_url = original_request.url url = prepared_request.url if "Authorization" in headers and self.should_strip_auth(original_url, url): # If we get redirected to a new host, we should strip out any # authentication headers. del headers["Authorization"] # .netrc might have more auth for us on our new host. new_auth = get_netrc_auth(url) if self.trust_env else None if new_auth is not None: prepared_request.prepare_auth(new_auth) def rebuild_proxies( self, prepared_request: PreparedRequest, proxies: dict[str, str] | None, ) -> dict[str, str]: """This method re-evaluates the proxy configuration by considering the environment variables. If we are redirected to a URL covered by NO_PROXY, we strip the proxy configuration. Otherwise, we set missing proxy keys for this URL (in case they were stripped by a previous redirect). This method also replaces the Proxy-Authorization header where necessary. :rtype: dict """ assert _is_prepared(prepared_request) headers = prepared_request.headers scheme = urlparse(prepared_request.url).scheme new_proxies = resolve_proxies(prepared_request, proxies, self.trust_env) if "Proxy-Authorization" in headers: del headers["Proxy-Authorization"] try: username, password = get_auth_from_url(new_proxies[scheme]) except KeyError: username, password = None, None # urllib3 handles proxy authorization for us in the standard adapter. # Avoid appending this to TLS tunneled requests where it may be leaked. if not scheme.startswith("https") and username and password: headers["Proxy-Authorization"] = _basic_auth_str(username, password) return new_proxies def rebuild_method( self, prepared_request: PreparedRequest, response: Response ) -> None: """When being redirected we may want to change the method of the request based on certain specs or browser behavior. """ method = prepared_request.method # https://tools.ietf.org/html/rfc7231#section-6.4.4 if response.status_code == codes.see_other and method != "HEAD": method = "GET" # Do what the browsers do, despite standards... # First, turn 302s into GETs. if response.status_code == codes.found and method != "HEAD": method = "GET" # Second, if a POST is responded to with a 301, turn it into a GET. # This bizarre behaviour is explained in Issue 1704. if response.status_code == codes.moved and method == "POST": method = "GET" prepared_request.method = method

Loading feature diagnosis…

Source regions

Feature contributions

Feature contributions

FeatureValueContribution
(log-odds)
Halstead volumeHow much symbolic information the code contains. It combines the total number of operators and values with the number of distinct ones.9288.619−306.524
Source linesThe number of non-empty source lines.319+127.6
Byte entropyHow varied the bytes in the source text are. Repeated bytes give a lower value; a more even mixture gives a higher value.4.404−6.606

Intercept 8.87 + feature contributions = -176.661 (log-odds).
Score = sigmoid(-176.661) = 0.

Feature contributions

FeatureValueContribution
(log-odds)
Comment layout frequencyHow frequently the layout switches between lines containing only comments or whitespace and lines containing code.320−10.294
Indentation frequencyHow rapidly indentation changes from line to line.251+7.945
Number layout frequencyHow rapidly the number of numeric values per line changes through the code.251−5.339
Identifier layout (vertical)How rapidly the visual pattern of identifier characters changes from top to bottom.318.872+4.047
Comment layout (horizontal)How rapidly the visual pattern of comment characters changes from left to right.92.941+0.695
Operator visual areaThe share of the code’s visual area occupied by operators such as +, =, and *.0.044+0.51
Identifier layout (horizontal)How rapidly the visual pattern of identifier characters changes from left to right. It measures spatial frequency, not the meaning of the names.92.944−0.272

Intercept 0.07 + feature contributions = -2.636 (log-odds).
Score = sigmoid(-2.636) = 0.067.

Score0.616
Score139
Run 1

The code is a mix of clear docstrings and comments with some severe readability issues. The import section is organized but excessively long. The `resolve_redirects` method is deeply nested with a while loop containing multiple conditional blocks and try/except statements, making it hard to follow. Most critically, lines 110-120 use bizarre `__import__('builtins')` calls to iterate over a tuple, which is completely unnecessary and severely impairs clarity - a simple for loop would be far more readable. The code has some good practices like descriptive variable names and helpful comments explaining non-obvious behavior, but the redirect resolution logic is complex and dense. Action granularity is inconsistent - some lines do too much, others are unnecessarily verbose. The reading flow is disrupted by the nested loops and unclear control flow. While the individual methods have clear purposes, the implementation details in some sections reduce overall readability significantly.

Run 2

While the code has good docstrings, type hints, and logical class organization, it suffers from several readability issues. The `resolve_redirects` method is very long and mixes multiple responsibilities, making it hard to follow. It contains an oddly written loop using `__import__('builtins')` instead of a simple `for` loop, which obscures intent. There are many inline comments, some explaining non-obvious behavior, but the overall flow is disrupted by deep nesting and long conditional blocks. The method also performs mutation, network calls, and history tracking all in one place. Other methods like `should_strip_auth` and `rebuild_proxies` are reasonably clear. Overall, the code is maintainable for domain experts but not highly readable for general audiences.

Run 3

The code is well-structured with clear method separation and descriptive naming. Nesting is generally shallow, though the while loop in resolve_redirects has many sequential operations. Intent is clear through docstrings and comments. One notable issue is the bizarre use of __import__('builtins').iter() instead of a standard for loop, which is unnecessarily complex and hurts readability. Code length is appropriate for the complexity, and action granularity is mostly one action per line. Reading flow is logical, following redirect handling naturally. The redundant get_redirect_target call is explained in comments. Overall, high readability with minor stylistic concerns.

Run 1

Code Structure: Cohesive redirect-handling class with well-separated authentication, proxy, and method helpers, although resolve_redirects combines many responsibilities. Nesting: Generally shallow, but the redirect loop contains several branches and an unnecessarily nested manual iterator. Clarity of intent: Descriptive method names, type annotations, docstrings, and protocol-related comments explain most behavior; abbreviated variables and unresolved annotation names slightly hinder understanding. Code length: Mostly justified by HTTP edge cases, but resolve_redirects is lengthy, and dynamic builtins imports plus explicit iterator handling needlessly replace a simple for loop. Action granularity: Almost every line performs one clear operation. Reading flow: Helpers and sequential processing stages provide a natural progression, but the manual iteration block interrupts otherwise idiomatic Python, and substantial mutable state requires careful tracking.

Run 2

Code Structure: Related redirect behavior is logically grouped in a mixin with focused helper methods, although resolve_redirects handles many responsibilities. Nesting: Most methods use shallow conditionals and early returns; the redirect loop introduces moderate nesting, worsened by an unnecessary nested iterator/exception loop. Clarity of intent: Descriptive method names, type annotations, docstrings, and protocol-specific comments explain purpose well. Abbreviations such as req and resp are conventional, but undefined annotation references in the excerpt add uncertainty. Code length: Generally justified by redirect complexity, though resolve_redirects is lengthy and manually iterating headers through dynamic builtins imports is needlessly verbose. Action granularity: Statements generally perform one action per line, with readable multiline calls and conditions. Reading flow: Redirect processing follows a coherent sequence from response cleanup through URL normalization, request rebuilding, and sending. However, the unusual loopIterator naming and repeated __import__ calls interrupt otherwise idiomatic Python and obscure a simple header-removal operation.

Run 3

Code Structure: Responsibilities are logically separated into redirect, authentication, proxy, and method helpers, but resolve_redirects handles many concerns. Nesting: Most methods are relatively flat, although the main redirect loop contains several nested branches and an unnecessarily nested iterator loop. Clarity of intent: Descriptive method names, type annotations, docstrings, and protocol-specific comments explain behavior well; abbreviated variables and unresolved type references slightly reduce clarity. Code length: Much of the length reflects legitimate HTTP edge cases, but resolve_redirects is long, and manually iterating through headers using dynamic builtins imports is needlessly verbose. Action granularity: Statements generally perform one action per line, with no dense chains of operations. Reading flow: Processing follows a sensible redirect lifecycle, supported by contextual comments, but the unconventional header-removal loop interrupts otherwise idiomatic Python and adds avoidable cognitive overhead.