Source code
package org.apache.kafka.streams.internals;
import org.apache.kafka.common.config.ConfigDef;
import org.apache.kafka.common.config.ConfigException;
import org.apache.kafka.common.utils.Utils;
import org.apache.kafka.streams.state.HostInfo;
public class ApplicationServerConfigValidator implements ConfigDef.Validator {
@Override
public void ensureValid(final String name, final Object value) {
if (!(value instanceof String)) {
throw new ConfigException(name + " must be a string");
}
final String endPoint = (String) value;
if (Utils.isBlank(endPoint)) {
return;
}
try {
HostInfo.buildFromEndpoint(endPoint);
} catch (final ConfigException e) {
throw new ConfigException(name, value, e.getMessage());
}
}
@Override
public String toString() {
return "A host:port pair, protocol://host:port, or an empty string";
}
}
Run 1
The code is highly readable. It follows a clear logical structure: type check, blank check, validation, and error wrapping. The method is flat with no deep nesting. Each action is on its own line, and the intent is straightforward. The toString method clearly documents acceptable formats. Minor improvements could include a more descriptive exception message, but overall the code is concise, well-organized, and easy to follow.
Run 2
The code is well-structured and highly readable. It has a clear, single responsibility and follows a logical flow: type check, blank check, validation, error wrapping. Nesting is minimal (only one try-catch block), and each action is on its own line, improving clarity. Method names and variable names are descriptive. The only minor deduction is for the slightly redundant instanceof check before casting, which adds a few extra lines, but it improves error messaging and is a common pattern in Kafka config validators.
Run 3
The code is highly readable with clear logical structure and minimal nesting. The class implements a single validation responsibility and each method serves a distinct purpose. The ensureValid method follows a natural flow: type check, blank handling, endpoint validation, and exception wrapping. While the nested try-catch adds minor depth, it is necessary for exception translation. The code is concise without being cryptic, and each line generally performs one action. Variable naming is clear, and the toString override clearly documents valid input formats. Overall, it demonstrates good Java practices and maintainable structure.
Run 1
Code Structure: A focused validator class cleanly separates validation from its descriptive string. Nesting: Shallow conditionals and an early return keep control flow flat. Clarity of intent: Descriptive names and explicit checks make type validation, blank-value acceptance, and endpoint validation easy to understand. Code length: Concise, with no unnecessary logic or repetition. Action granularity: Each statement performs one clear action. Reading flow: Validation proceeds naturally from checking the type to handling blank input and parsing the endpoint, with errors rethrown using configuration context. Minor readability improvements include separating the package declaration from imports with a blank line and using the conventional spelling 'endpoint' rather than 'endPoint'.
Run 2
Code Structure: Clearly organized into validation and description methods, with parsing delegated to HostInfo. Nesting: Shallow; guard clauses and an early return keep the main path flat. Clarity of intent: Descriptive class and method names make endpoint validation clear, although accepting blank input is not explicitly explained. Code length: Concise, with no unnecessary logic or duplication. Action granularity: Each statement performs one clear action. Reading flow: Naturally progresses from type checking to blank-value handling, endpoint parsing, and contextual exception reporting. Minor formatting improvements, such as separating the package declaration from imports, would improve readability further.
Run 3
Code Structure: The validator is logically organized, separating validation from its descriptive string. Nesting: Guard clauses and an early return keep nesting minimal; the try/catch is straightforward. Clarity of intent: Class and method names clearly communicate endpoint validation, and toString documents accepted formats. Code length: The implementation is concise without unnecessary abstraction or repetition. Action granularity: Each statement performs a single clear action. Reading flow: Validation proceeds naturally from type checking to blank handling, endpoint parsing, and error translation. Minor readability improvements include adding a blank line between the package declaration and imports and using the conventional spelling 'endpoint' rather than 'endPoint'.