Source code
package org.apache.kafka.streams.internals;
import org.apache.kafka.common.config.ConfigDef;
import org.apache.kafka.common.config.ConfigException;
import org.apache.kafka.common.utils.Utils;
import org.apache.kafka.streams.state.HostInfo;
public class ApplicationServerConfigValidator implements ConfigDef.Validator {
@Override
public void ensureValid(final String name, final Object value) {
if (!(value instanceof String)) {
throw new ConfigException(name + " must be a string");
}
final String endPoint = (String) value;
if (Utils.isBlank(endPoint)) {
return;
}
try {
HostInfo.buildFromEndpoint(endPoint);
} catch (final ConfigException e) {
throw new ConfigException(name, value, e.getMessage());
}
}
@Override
public String toString() {
return "A host:port pair, protocol://host:port, or an empty string";
}
}
Run 1
The code is highly readable. It follows a clear logical structure: type check, blank check, validation, and error wrapping. The method is flat with no deep nesting. Each action is on its own line, and the intent is straightforward. The toString method clearly documents acceptable formats. Minor improvements could include a more descriptive exception message, but overall the code is concise, well-organized, and easy to follow.
Run 2
The code is well-structured with a single clear responsibility: validating application server endpoints. It has minimal nesting (one if statement and one try-catch), making it easy to follow. The intent is immediately clear — ensure the value is a string, allow blank values, and validate non-blank endpoints. The code is concise with no unnecessary boilerplate. Each line performs one logical action, improving readability. The reading flow is natural: type check, blank check, validation, then error handling. The only minor deduction is that the error propagation in the catch block could be slightly more explicit about rethrowing a validation error, but overall this is highly readable code.
Run 3
The code is highly readable with a clear, logical structure. It uses early returns and guard clauses effectively, keeping nesting shallow. Each action is on its own line, and the intent is obvious: validate that a value is a string, allow blank values, and validate non-blank values as host endpoints. The try-catch is minimal and purposeful, wrapping only the parsing logic. Method names are descriptive, and the toString override provides helpful documentation. The only minor deductions are the slightly terse catch block and lack of a blank line between the early return and the try block, but these are negligible.
Run 1
Code Structure: A small, focused validator with logically separated validation and descriptive methods. Nesting: Shallow conditionals and an early return keep the main path flat. Clarity of intent: Descriptive class and method names make the purpose clear; endpoint parsing is delegated to HostInfo, and exceptions retain configuration context. Code length: Concise, with no unnecessary logic or duplication. Action granularity: Each statement performs one clear action on its own line. Reading flow: Type checking, blank-value handling, endpoint validation, and error reporting follow a natural sequence. Minor formatting improvements, such as separating the package declaration from imports with a blank line, would improve readability.
Run 2
Code Structure: The validator is logically organized into type checking, blank-value handling, and endpoint validation. Nesting: Guard clauses keep control flow flat, with only a straightforward try/catch. Clarity of intent: Descriptive class and method names make the purpose clear; toString documents accepted formats, though endpoint parsing details are delegated to HostInfo. Code length: The implementation is concise without unnecessary logic. Action granularity: Each statement performs one distinct action. Reading flow: Validation proceeds naturally from basic checks to parsing and error reporting. Minor formatting improvements, such as separating the package declaration from imports, would improve presentation.
Run 3
Code Structure: Logically organized into validation and descriptive methods. Nesting: Shallow conditionals and an early return keep control flow flat. Clarity of intent: Class and method names clearly communicate endpoint validation; blank values are explicitly accepted, though the rationale is not documented. Code length: Concise, with no unnecessary logic. Action granularity: Each statement performs a single action, making individual steps easy to follow. Reading flow: Naturally progresses from type checking to blank handling, endpoint validation, and error reporting. Minor formatting improvements, such as separating the package declaration from imports and adding space before the try block, would improve readability further.