Sample

int-cf986dc28342-I12

Inline all eligible single-use intermediate local variables

Matched original source

DatasetJava transformations
Lines103

Scores

MethodScoreScale
Posnett00–1; higher is more readable
Scalabrino0.4610–1; higher is more readable
Dorn0.7070–1; higher is more readable
Mi0.0380–1; higher is more readable
LLOC39Logical lines; fewer is more readable
DeepSeek V4 Pro16.670–20; mean of three runs
GPT-6.1 Sol17.670–20; mean of three runs
BTTF0.4640–1; higher is more readable

Views

Source code

package kafka.server.share; import kafka.cluster.Partition; import kafka.server.ReplicaManager; import org.apache.kafka.common.IsolationLevel; import org.apache.kafka.common.TopicIdPartition; import org.apache.kafka.common.errors.NotLeaderOrFollowerException; import org.apache.kafka.common.errors.OffsetNotAvailableException; import org.apache.kafka.common.record.internal.FileRecords; import org.apache.kafka.common.requests.ListOffsetsRequest; import org.apache.kafka.server.partition.PartitionListener; import org.apache.kafka.server.share.PartitionMetadataProvider; import org.apache.kafka.server.storage.log.FetchIsolation; import org.apache.kafka.storage.internals.log.LogOffsetMetadata; import org.apache.kafka.storage.internals.log.LogOffsetSnapshot; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import java.util.Optional; import scala.Some; /** * Implementation of {@link PartitionMetadataProvider} backed by {@link ReplicaManager}. */ public class ReplicaManagerPartitionMetadataProvider implements PartitionMetadataProvider { private static final Logger log = LoggerFactory.getLogger(ReplicaManagerPartitionMetadataProvider.class); private final ReplicaManager replicaManager; public ReplicaManagerPartitionMetadataProvider(ReplicaManager replicaManager) { this.replicaManager = replicaManager; } @Override public long offsetForEarliestTimestamp(TopicIdPartition topicIdPartition, int leaderEpoch) { // Isolation level is only required when reading from the latest offset hence use Option.empty() for now. Optional<FileRecords.TimestampAndOffset> timestampAndOffset = replicaManager.fetchOffsetForTimestamp( topicIdPartition.topicPartition(), ListOffsetsRequest.EARLIEST_TIMESTAMP, scala.Option.empty(), Optional.of(leaderEpoch), true).timestampAndOffsetOpt(); if (timestampAndOffset.isEmpty()) { throw new OffsetNotAvailableException("Offset for earliest timestamp not found for topic partition: " + topicIdPartition); } return timestampAndOffset.get().offset; } @Override public long offsetForLatestTimestamp(TopicIdPartition topicIdPartition, int leaderEpoch) { // Isolation level is set to READ_UNCOMMITTED, matching with that used in share fetch requests. Optional<FileRecords.TimestampAndOffset> timestampAndOffset = replicaManager.fetchOffsetForTimestamp( topicIdPartition.topicPartition(), ListOffsetsRequest.LATEST_TIMESTAMP, new Some<>(IsolationLevel.READ_UNCOMMITTED), Optional.of(leaderEpoch), true).timestampAndOffsetOpt(); if (timestampAndOffset.isEmpty()) { throw new OffsetNotAvailableException("Offset for latest timestamp not found for topic partition: " + topicIdPartition); } return timestampAndOffset.get().offset; } @Override public long offsetForTimestamp(TopicIdPartition topicIdPartition, long timestamp, int leaderEpoch) { Optional<FileRecords.TimestampAndOffset> timestampAndOffset = replicaManager.fetchOffsetForTimestamp( topicIdPartition.topicPartition(), timestamp, new Some<>(IsolationLevel.READ_UNCOMMITTED), Optional.of(leaderEpoch), true).timestampAndOffsetOpt(); if (timestampAndOffset.isEmpty()) { throw new OffsetNotAvailableException("Offset for timestamp " + timestamp + " not found for topic partition: " + topicIdPartition); } return timestampAndOffset.get().offset; } @Override public LogOffsetMetadata endOffsetMetadata(TopicIdPartition topicIdPartition, FetchIsolation isolation) { Partition partition = partition(topicIdPartition); LogOffsetSnapshot offsetSnapshot = partition.fetchOffsetSnapshot(Optional.empty(), true); if (isolation == FetchIsolation.LOG_END) return offsetSnapshot.logEndOffset(); else if (isolation == FetchIsolation.HIGH_WATERMARK) return offsetSnapshot.highWatermark(); else return offsetSnapshot.lastStableOffset(); } @Override public int leaderEpoch(TopicIdPartition topicIdPartition) { return partition(topicIdPartition).getLeaderEpoch(); } @Override public boolean addPartitionListener(TopicIdPartition topicIdPartition, PartitionListener listener) { return replicaManager.maybeAddListener(topicIdPartition.topicPartition(), listener); } @Override public void removePartitionListener(TopicIdPartition topicIdPartition, PartitionListener listener) { replicaManager.removeListener(topicIdPartition.topicPartition(), listener); } private Partition partition(TopicIdPartition topicIdPartition) { Partition partition = replicaManager.getPartitionOrException(topicIdPartition.topicPartition()); if (!partition.isLeader()) { log.debug("The broker is not the leader for topic partition: {}", topicIdPartition.topicPartition()); throw new NotLeaderOrFollowerException(); } return partition; } }

Loading feature diagnosis…

Source regions

Feature contributions

Feature contributions

FeatureValueContribution
(log-odds)
Halstead volumeHow much symbolic information the code contains. It combines the total number of operators and values with the number of distinct ones.4819.225−159.034
Source linesThe number of non-empty source lines.103+41.2
Byte entropyHow varied the bytes in the source text are. Repeated bytes give a lower value; a more even mixture gives a higher value.4.757−7.135

Intercept 8.87 + feature contributions = -116.099 (log-odds).
Score = sigmoid(-116.099) = 0.

Score0.461

Feature contributions

FeatureValueContribution
(log-odds)
Indentation frequencyHow rapidly indentation changes from line to line.99+2.687
Comment layout frequencyHow frequently the layout switches between lines containing only comments or whitespace and lines containing code.104−2.646
Identifier layout (horizontal)How rapidly the visual pattern of identifier characters changes from left to right. It measures spatial frequency, not the meaning of the names.142.99−2.391
Comment layout (horizontal)How rapidly the visual pattern of comment characters changes from left to right.142.981+1.502
Identifier layout (vertical)How rapidly the visual pattern of identifier characters changes from top to bottom.102.854+1.028
Number layout frequencyHow rapidly the number of numeric values per line changes through the code.1+0.398
Operator visual areaThe share of the code’s visual area occupied by operators such as +, =, and *.0.073+0.233

Intercept 0.07 + feature contributions = 0.881 (log-odds).
Score = sigmoid(0.881) = 0.707.

Score0.038
Score39
Run 1

The code is highly readable with a clear, logical structure and class-level responsibility. Methods are short, focused, and follow a consistent pattern for error handling. Nesting is minimal, with if/else branches in only two small methods. The intent is explicit, supported by descriptive method names, comments, and specific exception messages. Action granularity is mostly one action per line, though the final method chains a logger call with a throw; minor. The helper method `partition` effectively centralizes partition fetching and leader validation, reducing duplication. The lack of early returns in `endOffsetMetadata` is acceptable given its concise branching structure. Overall, the code demonstrates strong adherence to readability principles, with only minor verbosity in the repeated timestamp fetch blocks, which are still clear and understandable.

Run 2

The code is well-structured with clear separation of concerns and a single responsibility class. Methods are concise and follow consistent patterns, making the intent easy to understand. Nesting is minimal, and each method performs a focused action. However, readability is slightly reduced by long method calls with multiple arguments, especially `fetchOffsetForTimestamp` which spans several lines. The `endOffsetMetadata` method uses an if-else chain that could be slightly cleaner with a switch or guard clauses. Overall, the code is quite readable and maintainable.

Run 3

The code is well-structured with clear separation of concerns and consistent method organization. It follows a clean class-level design with a single responsibility. Nesting is minimal, with only simple if-else blocks in a few methods. Intent is clear from method names and the class implements a specific interface. Code length is appropriate, though there's some repetition in the three offset-fetching methods that could benefit from a private helper method. Action granularity is mostly good, with one primary operation per line. Reading flow is natural - methods are ordered logically and each performs a focused task. Small improvements could include extracting the repeated null-check pattern and simplifying the endOffsetMetadata if-else chain, but overall this is professional, maintainable code with good Java practices.

Run 1

Code Structure: Well-organized provider with focused methods and a shared partition-validation helper. Nesting: Shallow conditionals and early exceptions keep control flow simple. Clarity of intent: Descriptive method and variable names, interface overrides, and isolation-level comments explain the purpose; positional boolean arguments and mixed Java/Scala optional types add minor ambiguity. Code length: Generally concise, though three timestamp lookup methods repeat retrieval and error-handling logic. Action granularity: Statements largely perform one clear action, with modest chaining in lookup calls. Reading flow: Methods follow a natural progression from offset queries to metadata and listener operations, ending with the helper. Long argument lists and exception lines, compact import formatting, and unbraced conditionals slightly reduce readability.

Run 2

Code Structure: Well-organized class with focused interface methods and a shared partition-validation helper. Nesting: Shallow conditionals and straightforward exception paths keep complexity low. Clarity of intent: Descriptive method and variable names, explicit exceptions, and isolation-level comments clearly convey purpose; boolean arguments and mixed Java/Scala optional types add minor ambiguity. Code length: Generally concise, though three timestamp lookup methods repeat fetch and validation logic. Action granularity: Statements generally perform one action each, with only modest method chaining. Reading flow: Consistent formatting and predictable fetch-check-return sequences make the code easy to follow. Long argument lists, long exception lines, and omitted braces in endOffsetMetadata slightly reduce readability.

Run 3

Code Structure: Well-organized class with focused interface implementations and a shared partition lookup helper. Nesting: Shallow conditionals and straightforward returns keep complexity low. Clarity of intent: Descriptive method and variable names, explanatory isolation comments, and specific exceptions make behavior clear; boolean arguments and Java/Scala optional interoperability add minor ambiguity. Code length: Mostly concise, though three timestamp lookup methods repeat fetching and empty-result handling. Action granularity: Statements generally perform one action each, with only modest method chaining. Reading flow: Consistent formatting and predictable fetch-check-return sequences make the code easy to follow. Long argument lists and exception lines, tightly packed imports, and omitted braces in endOffsetMetadata slightly reduce readability.